Return default snapshot count to 10,000 #15408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Mar 6, 2023
The huge (100k+) value was justified when storev2 was being dumped completely with every snapshot. With storev2 being decomissioned we can checkpoint more frequently for faster recovery. Signed-off-by: James Blair <mail@jamesblair.net>
|
LGTM (note: this change should not be backported to <=3.5, for backward compatibility reasons). |
ptabor
approved these changes
Mar 6, 2023
serathius
approved these changes
Mar 6, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 100k value was justified when storev2 was being dumped completely with every snapshot.
With storev2 being decommissioned we should consider checkpointing more frequently for faster recovery and to avoid issues with purging wal files.
This pull request aims to generate discussion and hopefully consensus if now is the right time to return to the previous 10,000 snapshot count.
Note: If this pr is accepted I will raise the corresponding one for 3.6 documentation update.
Fixes #15360
/area performance