Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Reproduce issue 14685 #14909

Closed

Conversation

serathius
Copy link
Member

@serathius serathius force-pushed the linearizability-issue14685-real branch from 8c90fc5 to 898ed88 Compare December 7, 2022 22:49
Makefile Outdated
mkdir -p /tmp/etcd-release-v3.5.5/
cd /tmp/etcd-release-v3.5.5/; \
git clone https://github.com/etcd-io/etcd.git .; \
git checkout v3.5.5; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment #14912 (comment) applies to this PR as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this PR as draft until we resolve #14912 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the script. PTAL.

@serathius serathius marked this pull request as draft December 9, 2022 13:50
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius force-pushed the linearizability-issue14685-real branch from 898ed88 to b108fab Compare December 24, 2022 20:27
@serathius serathius marked this pull request as ready for review December 24, 2022 20:27
@codecov-commenter
Copy link

Codecov Report

Merging #14909 (b108fab) into main (a4c6d1b) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14909      +/-   ##
==========================================
- Coverage   74.75%   74.56%   -0.19%     
==========================================
  Files         415      415              
  Lines       34338    34267      -71     
==========================================
- Hits        25669    25552     -117     
- Misses       7034     7069      +35     
- Partials     1635     1646      +11     
Flag Coverage Δ
all 74.56% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/proxy/grpcproxy/register.go 50.00% <0.00%> (-19.77%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 74.47% <0.00%> (-8.34%) ⬇️
server/etcdserver/api/v3rpc/util.go 74.19% <0.00%> (-6.46%) ⬇️
server/lease/lease.go 94.87% <0.00%> (-5.13%) ⬇️
client/v3/concurrency/session.go 88.63% <0.00%> (-4.55%) ⬇️
client/pkg/v3/testutil/leak.go 62.83% <0.00%> (-4.43%) ⬇️
server/etcdserver/txn/util.go 96.42% <0.00%> (-3.58%) ⬇️
client/v3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
server/proxy/grpcproxy/watch.go 93.64% <0.00%> (-2.90%) ⬇️
client/v3/concurrency/election.go 79.68% <0.00%> (-2.35%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @serathius

@serathius
Copy link
Member Author

Interesting we got an inconsistency on GitHub side. Commit for this PR was merged but not the PR.
https://screenshot.googleplex.com/jGVe4zWhEzetuJD

@serathius serathius closed this Dec 25, 2022
@serathius serathius deleted the linearizability-issue14685-real branch June 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants