-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: commit the change generated by scripts/genproto.sh #14612
Conversation
TODO: ensure the generated code is up-to-date in the CI. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #14612 +/- ##
==========================================
- Coverage 75.39% 75.26% -0.13%
==========================================
Files 457 457
Lines 37125 37095 -30
==========================================
- Hits 27991 27921 -70
- Misses 7377 7420 +43
+ Partials 1757 1754 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR only regenerates some files, and the diff is mostly about changing the description. So I think the failure of test isn't caused by the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
We should have a test that makes sure that regeneration is an no-op.
The reason should be that we do not set down the versions, Lines 21 to 25 in f215cd8
We indeed to take care of it after we fix #14533 |
See etcd-io#14612 (comment) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
See etcd-io#14612 (comment) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
See etcd-io#14612 (comment) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
See etcd-io#14612 (comment) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
See etcd-io#14612 (comment) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
TODO: ensure the generated code is up-to-date in the CI.
Signed-off-by: spacewander spacewanderlzx@gmail.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.