Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: commit the change generated by scripts/genproto.sh #14612

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

spacewander
Copy link
Contributor

TODO: ensure the generated code is up-to-date in the CI.
Signed-off-by: spacewander spacewanderlzx@gmail.com

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

TODO: ensure the generated code is up-to-date in the CI.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #14612 (3a63a0d) into main (22cc682) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14612      +/-   ##
==========================================
- Coverage   75.39%   75.26%   -0.13%     
==========================================
  Files         457      457              
  Lines       37125    37095      -30     
==========================================
- Hits        27991    27921      -70     
- Misses       7377     7420      +43     
+ Partials     1757     1754       -3     
Flag Coverage Δ
all 75.26% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-9.31%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 73.43% <0.00%> (-4.17%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-3.89%) ⬇️
server/etcdserver/api/v3rpc/util.go 70.96% <0.00%> (-3.23%) ⬇️
server/etcdserver/cluster_util.go 70.35% <0.00%> (-3.17%) ⬇️
server/proxy/grpcproxy/watch.go 93.64% <0.00%> (-2.90%) ⬇️
client/v3/retry_interceptor.go 64.54% <0.00%> (-2.73%) ⬇️
server/etcdserver/api/rafthttp/pipeline.go 97.40% <0.00%> (-2.60%) ⬇️
server/etcdserver/api/v3rpc/auth.go 80.45% <0.00%> (-2.30%) ⬇️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spacewander
Copy link
Contributor Author

This PR only regenerates some files, and the diff is mostly about changing the description. So I think the failure of test isn't caused by the change.

Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

We should have a test that makes sure that regeneration is an no-op.

@serathius serathius merged commit f215cd8 into etcd-io:main Oct 24, 2022
@ahrtr
Copy link
Member

ahrtr commented Oct 24, 2022

We should have a test that makes sure that regeneration is an no-op.

The reason should be that we do not set down the versions,

etcd/scripts/genproto.sh

Lines 21 to 25 in f215cd8

GOFAST_BIN=$(tool_get_bin github.com/gogo/protobuf/protoc-gen-gofast)
GRPC_GATEWAY_BIN=$(tool_get_bin github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway)
SWAGGER_BIN=$(tool_get_bin github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger)
GOGOPROTO_ROOT="$(tool_pkg_dir github.com/gogo/protobuf/proto)/.."
GRPC_GATEWAY_ROOT="$(tool_pkg_dir github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway)/.."

We indeed to take care of it after we fix #14533

spacewander added a commit to spacewander/etcd that referenced this pull request Oct 31, 2022
See etcd-io#14612 (comment)
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/etcd that referenced this pull request Oct 31, 2022
See etcd-io#14612 (comment)
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/etcd that referenced this pull request Oct 31, 2022
See etcd-io#14612 (comment)
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/etcd that referenced this pull request Oct 31, 2022
See etcd-io#14612 (comment)
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/etcd that referenced this pull request Oct 31, 2022
See etcd-io#14612 (comment)
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants