clientv3: close streams after use in lessor keepAliveOnce method #14357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @amdprophet for the PR, but please submit a PR for |
Streams are now closed after being used in the lessor `keepAliveOnce` method. This prevents the "failed to receive lease keepalive request from gRPC stream" message from being logged by the server after the context is cancelled by the client. Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
amdprophet
force-pushed
the
close-keepalive-stream
branch
from
628a489
to
295044f
Compare
|
@ahrtr updated |
Codecov Report
@@ Coverage Diff @@
## main #14357 +/- ##
==========================================
- Coverage 75.40% 75.14% -0.27%
==========================================
Files 457 457
Lines 37139 37144 +5
==========================================
- Hits 28006 27913 -93
- Misses 7376 7461 +85
- Partials 1757 1770 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
cc @spzala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
client.KeepAliveOnceheavily in Sensu Go. Since upgrading to Etcd 3.5 we've seen an excessive amount of logs containingfailed to receive lease keepalive request from gRPC streamwhen logging at debug level. I believe this is happening as there's no attempt to close the stream after thekeepAliveOncemethod has completed. The stream is instead closed by the deferred call to cancel the context.The log lines no longer appear after attempting to close the stream using the code in this PR.