server/etcdmain: add configurable cipher list to gRPC proxy listener #14308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hah now I can 👮 you have to |
ahrtr
reviewed
Aug 8, 2022
ahrtr
reviewed
Aug 9, 2022
|
Please fix the format error, try to run |
|
Please also add an item into the changelog-3.6 |
Signed-off-by: Allen Ray <alray@redhat.com>
ahrtr
reviewed
Sep 9, 2022
Co-authored-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: Allen Ray <alray@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #14308 +/- ##
==========================================
- Coverage 75.34% 75.22% -0.13%
==========================================
Files 457 457
Lines 37185 37197 +12
==========================================
- Hits 28016 27980 -36
- Misses 7405 7447 +42
- Partials 1764 1770 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahrtr
approved these changes
Sep 12, 2022
|
@dusk125 I think we also need this in 3.5 and 3.4 respectively since the report dates back into openshift 4.8 |
This was referenced Sep 21, 2022
dusk125
pushed a commit
to dusk125/etcd
that referenced
this pull request
Nov 1, 2022
server/etcdmain: add configurable cipher list to gRPC proxy listener
dusk125
pushed a commit
to dusk125/etcd
that referenced
this pull request
Nov 2, 2022
server/etcdmain: add configurable cipher list to gRPC proxy listener
dusk125
pushed a commit
to dusk125/etcd
that referenced
this pull request
Nov 2, 2022
server/etcdmain: add configurable cipher list to gRPC proxy listener
dusk125
pushed a commit
to dusk125/etcd
that referenced
this pull request
Nov 2, 2022
server/etcdmain: add configurable cipher list to gRPC proxy listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially reopens #13362 cherrypicked onto main and with the requested test.