CHANGELOG: update version recommendation #14306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ahrtr @serathius |
Codecov Report
@@ Coverage Diff @@
## main #14306 +/- ##
==========================================
- Coverage 75.67% 75.34% -0.33%
==========================================
Files 456 456
Lines 37039 37039
==========================================
- Hits 28030 27908 -122
- Misses 7272 7372 +100
- Partials 1737 1759 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ahrtr
reviewed
Aug 3, 2022
CHANGELOG/README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Production recommendation | |||
|
|
|||
| The minimum recommended etcd versions to run in **production** are 3.3.18+, 3.4.2+, v3.5.3+. Refer to the [versioning policy](https://etcd.io/docs/v3.5/op-guide/versioning/) for more details. | |||
| The minimum recommended etcd versions to run in **production** are 3.4.2+ and v3.5.3+. Refer to the [versioning policy](https://etcd.io/docs/v3.5/op-guide/versioning/) for more details. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@ahrtr ok, that sounds good. Thanks!
spzala
force-pushed
the
updatechanglogversion
branch
from
23c34b2
to
061f348
Compare
ahrtr
reviewed
Aug 4, 2022
CHANGELOG/CHANGELOG-4.0.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| Previous change logs can be found at [CHANGELOG-3.x](https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.x.md). | |||
|
|
|||
|
|
|||
| The minimum recommended etcd versions to run in **production** are 3.2.28+, 3.3.18+, and 3.4.2+. | |||
| The minimum recommended etcd versions to run in **production** are v3.4.8+ and v3.5.4+. | |||
There was a problem hiding this comment.
I am thinking probably it makes more sense just to remove this in CHANGELOG-4.0, and keep the recommendation in one place CHANGELOG/README.md
What do you think? @spzala
There was a problem hiding this comment.
@ahrtr yes, good point! I am not sure why didn't we remove it when modified other files but probably it was missed. Thanks!
Update version recommendation per the current policy. For more details, see discussions under etcd-io/website#601 Signed-off-by: Sahdev Zala <spzala@us.ibm.com>
spzala
force-pushed
the
updatechanglogversion
branch
from
061f348
to
c9578c4
Compare
ahrtr
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update version recommendation per the current policy.
For more details, see discussions under
etcd-io/website#601
Signed-off-by: Sahdev Zala spzala@us.ibm.com