[3.4] Checkpoints fix 3.4 #14253
Merged
[3.4] Checkpoints fix 3.4 #14253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current checkpointing mechanism is buggy. New checkpoints for any lease are scheduled only until the first leader change. Added fix for that and a test that will check it. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
To extend lease checkpointing mechanism to cases when the whole etcd cluster is restarted. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
checkpoints-fix-3.4
branch
from
04b3db4
to
7079484
Compare
ahrtr
reviewed
Jul 22, 2022
server/embed/etcd.go
Outdated
| @@ -0,0 +1,860 @@ | |||
| // Copyright 2016 The etcd Authors | |||
There was a problem hiding this comment.
I do not understand why do you add this file (server/embed/etcd.go)? It seems it isn't needed in release-3.4.
There was a problem hiding this comment.
You need to update embed/etcd.go instead.
There was a problem hiding this comment.
Ups, looks like this was added as this file was not present in v3.4 branch.
…lease-checkpoint-persist to persist lease remainingTTL To avoid inconsistant behavior during cluster upgrade we are feature gating persistance behind cluster version. This should ensure that all cluster members are upgraded to v3.6 before changing behavior. To allow backporting this fix to v3.5 we are also introducing flag --experimental-enable-lease-checkpoint-persist that will allow for smooth upgrade in v3.5 clusters with this feature enabled. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
checkpoints-fix-3.4
branch
from
3a4d767
to
783e99c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Backport #13508
cc @ahrtr