Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring MaxConcurrentStreams for http2 #14169

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Support configuring MaxConcurrentStreams for http2 #14169

merged 6 commits into from
Jul 12, 2022

Commits on Jul 5, 2022

  1. support custom grpc.MaxConcurrentStreams 

    There is no update on the original PR (see below) for more then 2
weeks. So Benjamin(@ahrtr) continues to work on the PR. The first
step is to rebase the PR, because there are lots of conflicts with
the main branch.

The change to go.mod and go.sum reverted, because they are not needed.
The e2e test cases are also reverted, because they are not correct.

```
etcd-io#14081
```

Signed-off-by: nic-chen <chenjunxu6@gmail.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    杨金珏 authored and ahrtr committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    6220174 View commit details
    Browse the repository at this point in the history

  2. add & refine the uint32Value data type 

    The golang buildin package `flag` doesn't support `uint32` data
type, so we need to support it via the `flag.Var`.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    d8347ec View commit details
    Browse the repository at this point in the history

  3. set max concurrent streams to the http2 server 

    The default max stream is 250 in http2. When there are more then
250 streams, the client side may be blocked until some previous
streams are released. So we need to support configuring a larger
`MaxConcurrentStreams`.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    053ba95 View commit details
    Browse the repository at this point in the history

  4. add e2e test cases to cover the maxConcurrentStreams 

    Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    f40b676 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. update the comment for MaxConcurrentStreams to clearly state it's the… 

    … max value for each client.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    1a6fe4d View commit details
    Browse the repository at this point in the history

  2. add unit test for pkg/flags/Uint32FromFlag in uint32_test.go 

    Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    8b6c8b4 View commit details
    Browse the repository at this point in the history