-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.5] Dockerfile*: Switch baseimage to k8s hosted one #13862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I assume it's not a cherry-pick form main, as v3.6 stays on distro-less on purpose:
https://github.com/etcd-io/etcd/blob/main/Dockerfile-release.amd64
@ptabor exactly @serathius could we get this into the 3.5.3 release cycle?
vs
vs
vs k8s-bullseye with running apt-get update && apt-get upgrade -yy during build
vs
|
With critical issues present in current image we should consider adding this to v3.5.3, however:
|
See this about k8s.gcr.io debian-base containers: etcd was using it before: bad9a52 so I don't expect any breakage. CC @justaugustus or someone else from the k8s release team might be able to provide more context if needed. |
So Could we maybe ask K8s release folks to release |
We can certainly help out w/ that! |
As there was no progress from February I don't think new image will be ready for v3.5.3 which is expected within days (if nothing new pops up). Based on that I don't think it makes sense to block v3.5.3 on this. |
Alternatively, we should consider upgrading to at least debian:bullseye-20220328, I've added it to the table above. |
Makes sense, our goal should be providing images with least amount of vulnerabilities. Based on that I don't see any benefits from using k8s image until they push new image. On the other hand switching to |
Just a note that the latest debian-base from Kubernetes is k8s.gcr.io/build-image/debian-base:bullseye-v1.2.0. Can you scan against that? |
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Done, I added it to the table above. In the mean time I switched to a more recent debian:bullseye snapshot, happy to switch back to the k8s hosted one. |
I think this is good enough improvement for v3.5.3. Please add a release note in a separate PR. |
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@hexfusion
See also:
kubernetes/release@509fb40
https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/us/build-image/debian-base