Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG-3.5: update for #11427 #11432

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Conversation

YoyinZyc
Copy link
Contributor

@YoyinZyc YoyinZyc commented Dec 9, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #11432 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #11432     +/-   ##
=========================================
- Coverage   64.46%   64.37%   -0.1%     
=========================================
  Files         403      403             
  Lines       38071    38288    +217     
=========================================
+ Hits        24544    24649    +105     
- Misses      11888    11998    +110     
- Partials     1639     1641      +2
Impacted Files Coverage Δ
pkg/transport/timeout_conn.go 60% <0%> (-20%) ⬇️
etcdserver/api/v3rpc/util.go 51.61% <0%> (-16.13%) ⬇️
client/members.go 74.19% <0%> (-11.3%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
proxy/grpcproxy/watcher.go 85.71% <0%> (-8.17%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
auth/store.go 61.13% <0%> (-5.07%) ⬇️
etcdserver/api/v3rpc/watch.go 79.08% <0%> (-1.31%) ⬇️
proxy/grpcproxy/lease.go 79.18% <0%> (-0.91%) ⬇️
clientv3/client.go 74.42% <0%> (-0.58%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f35794...b5b1923. Read the comment docs.

CHANGELOG-3.5.md Outdated
@@ -80,6 +80,7 @@ Note that any `etcd_debugging_*` metrics are experimental and subject to change.
- [`etcd --backend-bbolt-freelist-type`] flag is now stable.
- `etcd --experimental-backend-bbolt-freelist-type` has been deprecated.
- Support [rollback/downgrade](TODO).
- Use v3 request to set cluster version and recover cluster version from v3 backend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include link to the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

CHANGELOG-3.5.md Outdated
@@ -80,6 +80,7 @@ Note that any `etcd_debugging_*` metrics are experimental and subject to change.
- [`etcd --backend-bbolt-freelist-type`] flag is now stable.
- `etcd --experimental-backend-bbolt-freelist-type` has been deprecated.
- Support [rollback/downgrade](TODO).
- Deprecate V2 apply on cluster version. [Use v3 request to set cluster version and recover cluster version from v3 backend](https://github.com/etcd-io/etcd/pull/11427).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/V2/v2 for consistency in the doc. Otherwise LGTM.

Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingyih jingyih merged commit b7d9f45 into etcd-io:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants