Panic in etcd gateway start #13810
Comments
|
I'd be happy to supply more log output. I did not find a way to get more verbose output from |
what is your |
`ValidateSecureEndpoints()` should call `t.DialContext()` instead of `t.Dial()`, because `t.Dial` is `nil`
`ValidateSecureEndpoints()` should call `t.DialContext()` instead of `t.Dial()`, because `t.Dial` is `nil`
The panics happens both on systems with and on systems without a Go installation. But I am guessing you are asking for a different reason, so I ran the commands you suggested on two of the affected systems that do have a Go installation: System 1: $ go version
go version go1.17.2 windows/amd64$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\tobias\AppData\Local\go-build
set GOENV=C:\Users\tobias\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\tobias\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\tobias\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.17.2
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\tobias\AppData\Local\Temp\go-build4036475500=/tmp/go-build -gno-record-gcc-switchesSystem 2: $ go version
go version go1.18 windows/amd64$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\tobias\AppData\Local\go-build
set GOENV=C:\Users\tobias\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\tobias\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\tobias\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.18
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set GOWORK=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\tobias\AppData\Local\Temp\go-build4094784673=/tmp/go-build -gno-record-gcc-switchesI am flexible in regards to Go versions and can install other versions if that's needed. |
`ValidateSecureEndpoints()` should call `t.DialContext()` instead of `t.Dial()`, because `t.Dial` is `nil`
`ValidateSecureEndpoints()` should call `t.DialContext()` instead of `t.Dial()`, because `t.Dial` is `nil`
`ValidateSecureEndpoints()` should call `t.DialContext()` instead of `t.Dial()`, because `t.Dial` is `nil`
Fix panic in etcd validate secure endpoints #13810
|
Thank you all! :-) |
`ValidateSecureEndpoints()` should call `t.DialContext()` instead of `t.Dial()`, because `t.Dial` is `nil`
|
Can the fix be ported to version 3.5? |
|
Ah yes, this isn't actually fixed in the v3.5 branch. Any plans to get that merged? That would be great and the original intent. |
|
@tskarman would you please provide the full log about this? I would like to help fix it. thanks Updated: the issue shows in windows platform? |
|
Sorry. It just needs to backport. File pr right now |
|
@tskarman the patch has been merged into 3.5. Closing it because 3.5.10 is coming soon. |
Cool :-) Thank you very much! |
What happened?
A panic happens when running
etcd gateway start --discovery-srv someplace.com --listen-addr=127.0.5.6:23790 --trusted-ca-file somepath/ca.pemin v3.5.2 where no panic happens when running it in v3.4.18.What did you expect to happen?
No panic, establish connection without error or fail with error message.
How can we reproduce it (as minimally and precisely as possible)?
The above command on Windows would do the trick.
I can give you the CA file and the DNS name privately. Just tell me where to send the information.
Anything else we need to know?
--insecure-discoverythe panic does not occur and things operate normally.GODEBUG=x509sha1=1,x509ignoreCN=0,http2debug=2and combinations thereof - no change and not further diagnostic output. Some of those options prob. even aren't valid anymore.Etcd version (please run commands below)
Etcd configuration (command line flags or environment variables)
gateway start --discovery-srv someplace.com --listen-addr=127.0.5.6:23790 --trusted-ca-file somepath/ca.pem
Etcd debug information (please run commands blow, feel free to obfuscate the IP address or FQDN in the output)
Relevant log output
The text was updated successfully, but these errors were encountered: