Protect custom type testers against None values#66
Merged
Conversation
Member
AntoineAugusti
left a comment
AntoineAugusti
left a comment
There was a problem hiding this comment.
Good work, sorry I miss the None case for SIREN/SIRET! 👏 for the tests
Comment on lines
+28
to
+29
| if d is None: | ||
| return d |
Member
There was a problem hiding this comment.
Is this needed? The next line casts to a string before trying to match the regex.
Contributor
Author
There was a problem hiding this comment.
tests fail w/o this so I guess so :-)
| def cast(self, d): | ||
| if d is None: | ||
| return d | ||
| if is_valid_siret(d) or is_valid_siren(d): |
Member
There was a problem hiding this comment.
These functions don't crash for non-string arguments?
Contributor
Author
There was a problem hiding this comment.
I think the tests cover this. And I'd say every value come as a string since it's a CSV and we're trying to guess types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cf https://github.com/wireservice/agate/blob/master/agate/data_types/boolean.py#L45 for inspiration
Fix #65