Skip to content

refactor(esx_dmvschool): code structure#76

Open
ghost wants to merge 6 commits intomainfrom
dmvschool-fix
Open

refactor(esx_dmvschool): code structure#76
ghost wants to merge 6 commits intomainfrom
dmvschool-fix

Conversation

@ghost
Copy link

@ghost ghost commented Oct 3, 2025

Description

  • Centralize TextUI display/hide functions (ShowDMVTextUI / HideDMVTextUI)
  • Remove duplicated code when opening/closing the menu
  • Ensure TextUI only shows when inside DMVSchool zone
  • Automatically hide TextUI when menu opens and show it when menu closes if still in zone
  • Clean up code for better readability and maintainability

PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@ghost ghost requested a review from N0tNvll October 3, 2025 22:44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats not german

@ghost ghost requested a review from zRxnx October 4, 2025 18:47
@N0tNvll
Copy link
Contributor

N0tNvll commented Oct 5, 2025

Make that the system have a better readable in client side pls
At the same time i continue seeing some parts of the code that can be refactorize

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rafael Antunes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants