Adjust Automatic Date Updates to Run on Save #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #221 , on-change events can be triggered twice due to the implementation of the change detection logic.
This is caused by
gray-matter
appending a newline character when rendering front matter content when the original file doesn't have a newline character, per: https://github.com/jonschlinkert/gray-matter/blob/master/lib/stringify.js#L51 . This is out of user control, which means that in all cases the extension will double-update the last modified property.The effort here removes the change detection logic altogether, instead using the
onWillSaveTextDocument
event as a proxy for when we should automatically update the last modified date. This is similar to how a file system might update the last modified property of the file on the file system, which makes sense.Testing