Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Unreadable text in some options of "Global settings" when using a light theme #202

Closed
cfnnmcg opened this issue Dec 4, 2021 · 1 comment
Milestone

Comments

@cfnnmcg
Copy link

cfnnmcg commented Dec 4, 2021

Issue
When using a light theme, such as Light+, the text under the "Modified date" and "Front Matter highlight" options becomes unreadable, and the checkboxes keep a dark color theme. This issue happens with every light theme I have installed.

To Reproduce
Steps to reproduce the behavior:

  1. Change to a light theme in VS Code.
  2. Open the Front Matter sidebar.
  3. Check the checkbox labels under "Modified date" and "Front Matter highlight".
  4. The aforementioned labels are unreadable, and the checkboxes use a dark color scheme.
  5. Also, the plus signs (+) in the Tags, Categories and Keywords fields use a dark color scheme too.

Expected behavior
The text and checkboxes should adapt to the light themes and be visible, regardless which theme is configured.

Screenshots

fm_01

fm_02

Desktop (please complete the following information):

  • OS: Windows 10 21H2
  • VS Code version: 1.62.3
@estruyf
Copy link
Owner

estruyf commented Dec 4, 2021

Thanks, @cfnnmcg. The checkbox styling issue seems to be coming from the VS Code web components dependency. I implemented a change to fix it.

The buttons are not using a dark color scheme, but they are just disabled. VS Code sets the brightness to 40% when disabled. Which means that this is the default behavior. Once you start typing, you'll notice the buttons should get the lighter green color from your theme.

@estruyf estruyf added this to the 5.7.0 milestone Dec 4, 2021
@estruyf estruyf closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants