Aliasing Distribution Causes Namespace Collision - #46
Conversation
**Description** The gem loads prior to the main application code and aliasing the gems namespace to a root namespace creates conflicts with main app. This update removes the aliasing to prevent this from happening. **Relates to Issue** estebanz01#45
|
Hey! thanks for your PR. I'll take a look at it. The problem with this approach is that you are removing the aliasing defined for distributions, so I'd need to do some lookup on usage of the gem dependents before merging it. |
Thanks! I assumed that the aliasing was only in place for convenience in testing. I hadn't thought that it had downstream effects. I would have thought the If this is in fact a breaking change I can modify the version to a major bump instead. Let me know if there is anything I can do to help! 😄 |
|
@beccachapin sorry the delay! Let's release this as a major bump 👍 |
removes distribution namespace aliasing **Description** This update remove the `Distribution` name space aliasing. To avoid issues it is recommended that any references to `Distribution` are replaced with the full name path `Statistics::Distribution` to avoid any disruption.
|
@estebanz01 Updated to version 3.0. I am a little unclear why the checks aren't running. Is there something I need to do? |
|
@beccachapin nah. It's something related to permissions that I never figured it out. Approved! Thaaaanks! |
|
I'll release it later today. 🥳 |
2 participants
Description
The gem loads prior to the main application code and aliasing the gems
namespace to a root namespace creates conflicts with main app. This
update removes the aliasing to prevent this from happening.
Relates to Issue
#45