Use imagePullSecrets if required

[estahn]

We currently rely on the registry being public. If imagePullSecrets is specified, this should be used for authentication.

• Image pull secrets from Pod ( see docs)
• Image pull secrets from ServiceAccount (see docs)
• Use informer to monitor secret changes

[jurgen-weber-deltatre]

this would be amazing... :)

[DolevAlgam]

Hey @estahn ,
Great work on this project!
Mirroring from private repos would help us too.
Do you have an estimate on the next version outdate?
Are you aware of any forks that started resolving this issue?
We are considering forking and implementing this ourselves, depending on your answers to my questions above.
Thank You!

[estahn]

@DolevAlgam Thanks. I started updating the dependencies last week (mainly slok/kubewebhook v1 -> v2). I can look into this issue potentially this week.

If you have resources to implement this and like to contribute I'm accepting PRs.

[DolevAlgam]

@estahn Cool.
When you say

If imagePullSecrets is specified, this should be used for authentication.

Do you mean the imagePullSecrets field of the pods being deployed on the cluster or the imagePullSecrets field of the service account deployed for the k8s-image-swapper?

[estahn]

@DolevAlgam Ideally both, but I assume the ServiceAccount scenario is more complex.

[DolevAlgam]

@estahn a PR for using the Pull Secrets defined in the pod for pulling its source image will be created in the following days.

[estahn]

@estahn a PR for using the Pull Secrets defined in the pod for pulling its source image will be created in the following days.

That's good news. I'm on vacation for the next few weeks in remote locations. Will pick this up as soon as I can.

[DolevAlgam]

@estahn a PR for using the Pull Secrets defined in the pod for pulling its source image will be created in the following days.

That's good news. I'm on vacation for the next few weeks in remote locations. Will pick this up as soon as I can.

No Problem :)
PR #92 has been created.

[estahn]

@DolevAlgam Just FYI, I'm back from vacation and will have a look at it in the next couple of days.

[DolevAlgam]

@estahn Hey,
Did you have the time to check out the PR?
Thanks.

[estahn]

@estahn Hey,
Did you have the time to check out the PR?
Thanks.

I have just pushed the update for slok/kubewebhook. Would you mind resolving the conflicts?