-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ECCW-509): DDEV commands, phpcs*.xml, phpunit*.xml. #465
Conversation
Merge release 202404-01 to main
Merge release/202406-03 into main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Polynya - Do you suppose the Failed to run
msg is due to the items it couldn't fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so. The error message is a bit confusing. Maybe we need a script to check the error code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing. For me, phpunit-lgd is getting stuck on the FunctionalJavascript tests. When I ran it a few weeks ago it got to the end and reported all the deprecations. For the ECC tests I added this variable
export SYMFONY_DEPRECATIONS_HELPER=weak
I've added an extra command without this - ddev phpunit-with-deprecations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to add a test to a module in the next PR when I add testing to the pipeline.
…drupal into feature/ECCW-693
…pal into feature/ECCW-693
…drupal into feature/ECCW-693
Stopping Review App and clearing up |
Include a summary of what this merge request involves (*)
This is the first of a series of tickets to improve testing.
Based on files in localgov profile.
DDEV commands:
XML files:
Call out any relevant implementation decisions
Are there any links to back up your chosen methodology?
Why have you taken the approach?
PHPCS reports issues in ecc_theme themes but PHPCBF does not fix them. This is to ensure that the developer fixes and commits the changes to the ecc_theme repo.
Any particular problem areas?
If necessary, please include any relevant screenshots (If not already available on the JIRA ticket)
This PR has been tested in the following browsers