refactor(sun): Use Astral for sunset/sunrise #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the previous custom sunset and sunrise calculation logic with the `astral` package. The `astral` package provides a more robust and accurate method for calculating these times, taking into account factors such as elevation and atmospheric refraction. This change improves the overall accuracy of zmanim calculations, particularly for locations with significant elevation or unusual atmospheric conditions. The following updates were made: - Removed custom sunset and sunrise calculation functions. - Installed the `astral` package. - Updated `zmanim` calculations to use `astral`'s API for determining sunrise and sunset. - Updated unit tests to reflect the new calculation method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the previous custom sunset and sunrise calculation logic with the
astralpackage.The
astralpackage provides a more robust and accurate method for calculating these times, taking into account factors such as elevation and atmospheric refraction.This change improves the overall accuracy of zmanim calculations, particularly for locations with significant elevation or unusual atmospheric conditions.
The following updates were made:
astralpackage.zmanimcalculations to useastral's API for determining sunrise and sunset.