Skip to content

Issue 503b: change Twos_Complement to TwosComplement #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotan merged 1 commit into from
Nov 15, 2021
Merged

Issue 503b: change Twos_Complement to TwosComplement #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/design/model.uml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ Just provide a specizlization of this trait for your type (class).</body>
<ownedLiteral xmi:type="uml:EnumerationLiteral" xmi:id="_A1EZoJPAEeeoI7oI9Ds2zg" name="BE"/>
</packagedElement>
<packagedElement xmi:type="uml:Enumeration" xmi:id="_SEPQ0JO_EeeoI7oI9Ds2zg" name="Sign">
<ownedLiteral xmi:type="uml:EnumerationLiteral" xmi:id="_8xR0EJO_EeeoI7oI9Ds2zg" name="Twos_Complement"/>
<ownedLiteral xmi:type="uml:EnumerationLiteral" xmi:id="_8xR0EJO_EeeoI7oI9Ds2zg" name="TwosComplement"/>
<ownedLiteral xmi:type="uml:EnumerationLiteral" xmi:id="_9hODQJO_EeeoI7oI9Ds2zg" name="Unsigned"/>
</packagedElement>
<packagedElement xmi:type="uml:Enumeration" xmi:id="_UUli0JO_EeeoI7oI9Ds2zg" name="Norm">
Expand Down
4 changes: 2 additions & 2 deletions doc/source/users_guide/dataspace.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ the dataspace there is currently

.. cpp:enum-class:: Type

.. cpp:enumerator:: SIMPLE
.. cpp:enumerator:: Simple

for a simple datatype

.. cpp:enumerator:: SCALAR
.. cpp:enumerator:: Scalar

for a scalar datatype

Expand Down
2 changes: 1 addition & 1 deletion src/h5cpp/datatype/types.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ std::ostream &operator<<(std::ostream &stream, const Order &o) {

std::ostream &operator<<(std::ostream &stream, const Sign &s) {
switch (s) {
case Sign::Twos_Complement: return stream << "TWOS COMPLEMENT";
case Sign::TwosComplement: return stream << "TWOS COMPLEMENT";
case Sign::Unsigned: return stream << "UNSIGNED";
default:return stream;
}
Expand Down
2 changes: 1 addition & 1 deletion src/h5cpp/datatype/types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ DLL_EXPORT std::ostream &operator<<(std::ostream &stream, const Order &o);
//!
enum class Sign : std::underlying_type<H5T_sign_t>::type
{
Twos_Complement = H5T_SGN_2, //!< indicates a signed type
TwosComplement = H5T_SGN_2, //!< indicates a signed type
Unsigned = H5T_SGN_NONE //!< indicates an unsigned type
};

Expand Down
2 changes: 1 addition & 1 deletion test/datatype/type_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ SCENARIO("Enumeration stream IO") {
GIVEN("write the sign enumeration") {
using ptype = std::tuple<Sign, std::string>;
auto param = GENERATE(table<Sign, std::string>(
{ptype{Sign::Twos_Complement, "TWOS COMPLEMENT"},
{ptype{Sign::TwosComplement, "TWOS COMPLEMENT"},
ptype{Sign::Unsigned, "UNSIGNED"}}));
WHEN("writing the sign to the stream") {
stream << value(param);
Expand Down