Issue 510: improve checks in Dataset.write/Dataset.read for 1D objects#511
Merged
eugenwintersberger merged 1 commit intomasterfrom Oct 23, 2021
Merged
Issue 510: improve checks in Dataset.write/Dataset.read for 1D objects#511eugenwintersberger merged 1 commit intomasterfrom
eugenwintersberger merged 1 commit intomasterfrom
Conversation
eugenwintersberger
approved these changes
Oct 23, 2021
Collaborator
eugenwintersberger
left a comment
eugenwintersberger
left a comment
There was a problem hiding this comment.
Looks good for me. We should maybe add some more comments in the code to document why we are doing things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It improves checks in Dataset.write/Dataset.read for 1D objects ( issue (e) of #510) to speed-up the method.