node tests crash on startup

[planetmarshall]

node tests crash on startup due to static initialization of objects wth invalid handles. See

h5cpp/test/node/virtual_dataset_test.cpp

Line 53 in 5b7c5a1

const static property::FileCreationList gfcpl;

Steps to reproduce

Build and run node_test

Expected results

The tests run and pass

Actual results

The executable fails to startup with

HDF5-DIAG: Error detected in HDF5 (1.12.0) thread 0:
  #000: H5P.c line 253 in H5Pcreate(): not a property list class
    major: Invalid arguments to routine
    minor: Inappropriate type
libc++abi: terminating with uncaught exception of type std::runtime_error: ObjectHandle: constructor failed, invalid hid=-1

[jkotan]

@planetmarshall, I could not reproduce the problem. Where you get the issue i.e. on which system?

[planetmarshall]

Yes I can reproduce on some systems but not others. Let me try and reproduce it in a container and I'll get back to you.

[jkotan]

Thanks. Indeed, I can reproduce it . It is because

  const static property::FileCreationList gfcpl;
  const static property::FileAccessList gfapl;

cannot be created before kFileCreate kFileAccess. For similar reason to create const static DatasetTransferList I had to use directly H5P_DATASET_XFER at

h5cpp/src/h5cpp/property/dataset_transfer.hpp

Line 89 in 93b742f

const static DatasetTransferList & dtpl_ = DatasetTransferList(ObjectHandle(H5Pcreate(H5P_DATASET_XFER)), false);

I will create workaround for it. Other option would be to make the 'k' Class variables static ones.