Open
Conversation
Filters are exported as a String which add too many escape characters. This commit changes the exported filter to JSON. The Content field from the exported json is still string and still includes the escape characters. Exporting JSON needs lot of changes and can be tackled in separate PR. Fixes: esrlabs#2475
AmmarAbouZor
requested changes
Feb 5, 2026
Member
AmmarAbouZor
left a comment
AmmarAbouZor
left a comment
There was a problem hiding this comment.
This doesn't work. I've tested the function export all to file in the context menu for the filters. Then I've tested the output with cat and the escape characters are still there.
Also, I would try to make the changes as small as possible and make them only in the export function to avoid any unnecessary changes on the main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters are exported as a String which add too many escape characters. This commit changes the exported filter to JSON.
The Content field from the exported json is still string and still includes the escape characters. Exporting JSON needs lot of changes and can be tackled in separate PR.
Fixes: #2475