index.js - persist showAll across refreshLibrary calls #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Update: I thought storing scroll position was overkill, but every once in a while it does jump a little without it. Adding that now. |
Contributor
Author
False alarm -- it was that text/icons changing were causing stuff on the page to move a little, the scroll position was constant. |
Member
|
Thanks! This looks like a great idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially fixes espruino/BangleApps#4003
Since options.showAll is only ever set to true once when expanding the library (I think?), I'm not sure where best to "store" it besides in a global next to the "activeSort" on the line above it.