Recorder: Use average of HR readings #4066
Merged
+37
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version saved the last sent HR reading when saving to CSV. Updated to maintain an average of all HR readings during each recording interval (only readings with confidence > 80), and save this instead. If no readings pass confidence threshold, the reading with the highest confidence is saved.
Member
|
Looks great - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Recorder saves the last sent HR reading when saving to CSV for each recording interval. This updates the app to keep a running average of all HR readings during each interval (only readings with confidence > 80), and saves this instead. If no readings pass the confidence threshold, the reading with the highest confidence is saved.
See discussion: https://github.com/orgs/espruino/discussions/7888