Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: random: Factored out v_noise #3349

Merged
merged 3 commits into from
Dec 3, 2019
Merged

core: random: Factored out v_noise #3349

merged 3 commits into from
Dec 3, 2019

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Dec 2, 2019

Description of changes:

  • Factored out v_noise function
  • Removed unused code

@fweik fweik requested a review from jngrad December 2, 2019 10:42
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #3349 into python will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3349   +/-   ##
======================================
- Coverage      86%     86%   -1%     
======================================
  Files         538     537    -1     
  Lines       25312   25283   -29     
======================================
- Hits        21785   21756   -29     
  Misses       3527    3527
Impacted Files Coverage Δ
src/core/random.cpp 68% <ø> (-1%) ⬇️
src/core/dpd.cpp 92% <100%> (-1%) ⬇️
src/core/random.hpp 70% <100%> (+26%) ⬆️
src/core/thermostat.hpp 96% <100%> (-1%) ⬇️
src/core/bonded_interactions/thermalized_bond.hpp 100% <100%> (ø) ⬆️
...ore/grid_based_algorithms/lb_particle_coupling.cpp 98% <100%> (-1%) ⬇️
src/utils/include/utils/u32_to_u64.hpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebaa24...d94e351. Read the comment docs.

Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad jngrad merged commit 4cec2ec into espressomd:python Dec 3, 2019
@RudolfWeeber RudolfWeeber added this to the Espresso 4.1.2 milestone Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants