Matrix product and Langevin simplification #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3301 +/- ##
======================================
- Coverage 86% 86% -1%
======================================
Files 536 536
Lines 25554 25564 +10
======================================
+ Hits 21985 21989 +4
- Misses 3569 3575 +6
Continue to review full report at Codecov.
|
jngrad
approved these changes
Nov 12, 2019
|
I disagree, the name for the matrix transformation was wrong ^^ |
|
This creates a merge conflict with the Brownian Dynamics pr. A merge order needs to be chosen.
|
jngrad
reviewed
Nov 12, 2019
|
We probably should rename the vector transform functions to |
|
On Tue, Nov 12, 2019 at 02:15:40AM -0800, Florian Weik wrote:
We probably should rename the vector transform functions to `convert_body_to_space`?
I can rebase the BD PR, did we decided to merge that?
Yes. See notes on the offline discussion with Bogdan from the school on the PR.
|
|
bors r=jngrad |
bors bot
added a commit
that referenced
this pull request
Nov 12, 2019
3301: Matrix product and Langevin simplification r=jngrad a=fweik Description of changes: - 3x3 matrix product for Utils::Matrix - space to body frame conversion for linear maps - Some simplification of the langevin thermostat Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: