Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update embed git python #999

Merged
merged 1 commit into from
Jun 29, 2023
Merged

update embed git python #999

merged 1 commit into from
Jun 29, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jun 20, 2023

Description

Update embed python and embed git to fix checking for existing paths.

Fixes #996
Fixes #1000

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "Configure ESP-IDF extension" command
  2. Run the setup wizard
  3. Observe results. Check that the downloaded python is 3.11.2 and git is 2.39.2
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Jun 20, 2023
@github-actions
Copy link

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 added this to the 1.6.4 milestone Jun 29, 2023
@brianignacio5 brianignacio5 merged commit 3bf9c21 into master Jun 29, 2023
@brianignacio5 brianignacio5 deleted the bugfix/update-embed-python branch June 29, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants