Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gitee links #972

Merged
merged 6 commits into from
Jun 30, 2023
Merged

add gitee links #972

merged 6 commits into from
Jun 30, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented May 15, 2023 •
edited
Loading

Description

Add gitee mirrors for ESP-IDF download for Espressif download server in extension setup.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Configure ESP-IDF extension"
  2. Execute setup using the Espressif download server.
  3. Observe results. ESP-IDF should be clone from gitee for master and release branches (which use git clone download strategy)
  • Expected behaviour: Cloning of ESP-IDF from gitee servers.

How has this been tested?

Manual test of ESP-IDF master branch install

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this May 15, 2023
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited
Loading

Download the artifacts for this pull request:

radurentea
radurentea approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Jun 15, 2023
@brianignacio5 brianignacio5 removed the stale Stale PR or Issue label Jun 19, 2023
@brianignacio5 brianignacio5 merged commit bf070b4 into master Jun 30, 2023
@brianignacio5 brianignacio5 deleted the enhance/gitee branch June 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radurentea radurentea radurentea approved these changes

Assignees

@brianignacio5 brianignacio5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianignacio5 @radurentea