Skip to content

Conversation

Diegorro98
Copy link
Contributor

Description

Now is installed when bootstrapping Matter and the the installation path has changed, so ZAP_INSTALL_PATH has been also updated.

See espressif/esp-matter@592e135

Type of change

  • Small change (non-breaking change which fixes an issue)

Steps to test this pull request

Launch ESP-Matter install command, then try to build an esp-matter project.

How has this been tested?

Same than above.

Test Configuration:

  • ESP-IDF Version: 4.4.3
  • OS (Windows,Linux and macOS): Linux

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms
    • Linux
    • macOS

Now is installed when bootstrapping Matter.

As the installation path has changed, ZAP_INSTALL_PATH has been also updated.

See espressif/esp-matter@592e135
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit a00cbf4 into espressif:master May 23, 2023
@Diegorro98 Diegorro98 deleted the no_zap_installation branch May 23, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants