Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix args order build task #848

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix args order build task #848

merged 1 commit into from
Nov 29, 2022

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Nov 25, 2022

Description

Check that build compiler arguments doesn't already exists before adding them to the list. Make sure to add the CCache argument at the end.

Fix #837

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manual build test on Windows

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Nov 25, 2022
@brianignacio5 brianignacio5 merged commit 8c54b7a into master Nov 29, 2022
@brianignacio5 brianignacio5 deleted the bugfix/ccache-build-arg branch November 29, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake Error: No source directory specified for -S (VSC-1004)
1 participant