Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pigweed path (VSC-982) #816

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fixed pigweed path (VSC-982) #816

merged 1 commit into from
Oct 11, 2022

Conversation

Diegorro98
Copy link
Contributor

@Diegorro98 Diegorro98 commented Oct 8, 2022

Description

pigweed path is wrong because it points to path/to/esp-matter/connectedhomeip/connectedhomeip/.environment/cipd/pigweed/ instead of pointing to path/to/esp-matter/connectedhomeip/connectedhomeip/.environment/cipd/packages/pigweed/ (packages was missing).

Fixes # (VSC-981)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  1. Run "Install ESP-Matter".
  2. On prompt, select "No, download ESP32 platform specific submodules only".
  3. Open an ESP-Matter example and build. Build should be succesfull.

Test Configuration:

  • ESP-IDF Version: 4.4.2
  • OS (Windows,Linux and macOS): Linux

Dependent components impacted by this PR:

  • ESP-Matter

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
    Verified on platforms:
    • Windows
    • Linux
    • macOS

@brianignacio5
Copy link
Collaborator

But Pigweed is added in here

Is it not already in Path when you build the ESP-Matter example ?

@github-actions github-actions bot changed the title Added pigweed path to customExtraPaths Added pigweed path to customExtraPaths (VSC-982) Oct 10, 2022
@Diegorro98
Copy link
Contributor Author

@brianignacio5 Completely true.
It doesn't work because the path is wrong.
I going to force push the fix on the same branch it and edit the pull request to avoid opening a new one.

@Diegorro98 Diegorro98 changed the title Added pigweed path to customExtraPaths (VSC-982) Fixed pigweed path (VSC-982) Oct 10, 2022
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the bug fix!

@brianignacio5 brianignacio5 merged commit ca2af26 into espressif:master Oct 11, 2022
@Diegorro98 Diegorro98 deleted the bugfix/pigweedPath branch October 11, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants