Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance project structure (VSC-277) #73

Merged
merged 10 commits into from
Apr 23, 2020
Merged

Enhance project structure (VSC-277) #73

merged 10 commits into from
Apr 23, 2020

Conversation

pwmb
Copy link
Contributor

@pwmb pwmb commented Mar 28, 2020

Enhance Project Structure by:

  • Removing some of the unused files
  • Moving the logo to the media folder
  • Ignore gulp script in vsix

pwmb added 5 commits March 16, 2020 18:19
@pwmb
Merge pull request #1 from espressif/master
069c1b1 
Merge master from espressif/vscode-esp-idf-extension
@pwmb
Merge pull request #2 from espressif/master
00dbd8c 
Merge commit
@pwmb
Merge pull request #3 from espressif/master
08e1a73 
Master merge
@pwmb
Merge pull request #4 from espressif/master
4222336 
merge from GH master
@pwmb
Removed unused files
78ae3da 
Removed gulp script from vsix
moved the logo to media folder
@pwmb pwmb added the Project Enhancement Enhance the project structure, CI, or any part which improves the quality of development in the repo label Mar 28, 2020
@pwmb pwmb requested review from kumekay and brianignacio5 March 28, 2020 06:31
@github-actions github-actions bot changed the title Enhance project structure Enhance project structure (VSC-277) Mar 28, 2020
@brianignacio5
Copy link
Collaborator

Should we have prettier for Python files or have bandit/flake in the subdirectory ?

@pwmb
Copy link
Contributor Author

pwmb commented Mar 31, 2020

Should we have prettier for Python files or have bandit/flake in the subdirectory ?

Well prettier don't have python support and in their github they suggest to use black. I will try it and if its good we can add this to format our python code

but as of not these bandid/flake8 files which i removed didn't do anything since they were not run in CI or in the npm scripts as well and both the script also have added esp_debug_adapter to ignore list

@kumekay
Copy link
Collaborator

kumekay commented Apr 5, 2020

Well prettier don't have python support and in their github they suggest to use [black]

We use yapf to format code in all other projects (and here too https://github.com/espressif/vscode-esp-idf-extension/blob/master/.style.yapf ), so it's better to stick with it in this project too.

@pwmb
Copy link
Contributor Author

pwmb commented Apr 13, 2020

We use yapf to format code in all other projects

Correct, haven't modified that file, just some file which were un-used in the repo

@pwmb pwmb added this to the Release Candidate v0.2.1 milestone Apr 20, 2020
brianignacio5
brianignacio5 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Python lint related conversation should happen in a new PR.

@pwmb pwmb merged commit 5fe58ae into espressif:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianignacio5 brianignacio5 brianignacio5 approved these changes

@kumekay kumekay Awaiting requested review from kumekay

Assignees
No one assigned
Labels
Project Enhancement Enhance the project structure, CI, or any part which improves the quality of development in the repo
Projects
None yet
Milestone
Release Candidate v0.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@pwmb @brianignacio5 @kumekay