Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/release ci actions #378

Merged
merged 3 commits into from
Apr 23, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix ci workflows
  • Loading branch information
brianignacio5 committed Apr 23, 2021
commit a067e1ff2f4f343461fbbce76efd51f59703e509
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,6 @@ jobs:
- name: Lint Check
run: yarn lint

- name: Package .vsix
run: yarn package

- name: Upload .vsix File
uses: actions/upload-artifact@v1
with:
name: esp-idf-extension.vsix
path: esp-idf-extension.vsix

- name: Package open .vsix
run: yarn packageWithoutDependencies

Expand All @@ -54,6 +45,15 @@ jobs:
name: esp-idf-extension-open.vsix
path: esp-idf-extension-open.vsix

- name: Package .vsix
run: yarn package

- name: Upload .vsix File
uses: actions/upload-artifact@v1
with:
name: esp-idf-extension.vsix
path: esp-idf-extension.vsix

- name: Extension Test
uses: GabrielBB/xvfb-action@v1.2
with:
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
- name: Install Dependencies
run: yarn

- name: Package open .vsix
run: yarn run packageWithoutDependencies

- name: VSIX Package
run: yarn run package

Expand Down Expand Up @@ -56,6 +59,17 @@ jobs:
asset_name: esp-idf-extension-${{ steps.version.outputs.version }}.vsix
asset_content_type: application/zip

- name: Upload no dependencies release asset
id: upload-release-asset
uses: actions/upload-release-asset@v1.0.1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ./esp-idf-extension-open.vsix
asset_name: esp-idf-extension-open-${{ steps.version.outputs.version }}.vsix
asset_content_type: application/zip

- name: Marketplace release
run: yarn run release
env:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@
"watch": "webpack --watch --mode development",
"test": "tsc -p ./ && node ./out/test/runTest.js --VERBOSE 2>&1 >> testing.results.log",
"package": "vsce package --yarn -o esp-idf-extension.vsix",
"release": "vsce publish --yarn -p ${VS_MARKETPLACE_TOKEN}",
"release": "vsce publish --yarn -p ${VS_MARKETPLACE_TOKEN} --packagePath esp-idf-extension.vsix",
"clean": "gulp clean",
"validateLocalization": "gulp validateLocalization",
"webpack": "webpack --mode production",
Expand Down