Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDF component manager in extensions tasks #374

Merged
merged 1 commit into from
Apr 23, 2021
Merged

IDF component manager in extensions tasks #374

merged 1 commit into from
Apr 23, 2021

Conversation

brianignacio5
Copy link
Collaborator

Add IDF_COMPONENT_MANAGER = "1" and idf-component-manager as extension python package requirement.

@brianignacio5 brianignacio5 added the enhancement New feature or request label Apr 22, 2021
@brianignacio5 brianignacio5 requested a review from kumekay April 22, 2021 12:42
kumekay
kumekay approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@kumekay kumekay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Brian

@brianignacio5 brianignacio5 merged commit 18fc174 into master Apr 23, 2021
@brianignacio5 brianignacio5 deleted the enhance/component-manager-enable branch April 23, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumekay kumekay kumekay approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianignacio5 @kumekay