Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Russian localization (VSC-491) #216

Merged
merged 13 commits into from
Jan 19, 2021
Merged

Conversation

Vasilius-001
Copy link
Contributor

Added Russian localization based on English

@pwmb pwmb requested review from brianignacio5 and igrr November 14, 2020 01:28
@pwmb pwmb added the enhancement New feature or request label Nov 14, 2020
@pwmb pwmb added this to the next milestone Nov 14, 2020
@pwmb pwmb requested a review from kumekay November 17, 2020 06:00
@github-actions
Copy link

github-actions bot commented Dec 3, 2020

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Dec 3, 2020
@pwmb pwmb added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Dec 3, 2020
@pwmb
Copy link
Contributor

pwmb commented Dec 3, 2020

Sorry for such a delay, some of our colleagues who knows Russian are very busy at the moment and they will take a look into this ASAP.

@github-actions github-actions bot changed the title Added Russian localization Added Russian localization (VSC-491) Dec 3, 2020
i18n/ru/out/espIdf/menuconfig/MenuconfigPanel.i18n.json Outdated Show resolved Hide resolved
@@ -0,0 +1,12 @@
{
"menuconfig.panelName": "Редактор конфигурации SDK",
"menuconfig.loadDefaultValues": "Загружены настройки по умолчанию в редакторе конфигурации SDK",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianignacio5 It looks like menuconfig.loadDefaultValues is not used in the code. When should it appear?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianignacio5 same here!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove.

i18n/ru/out/espIdf/menuconfig/MenuconfigPanel.i18n.json Outdated Show resolved Hide resolved
i18n/ru/out/espIdf/menuconfig/MenuconfigPanel.i18n.json Outdated Show resolved Hide resolved
i18n/ru/out/espIdf/serial/SerialPort.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
@kumekay
Copy link
Collaborator

kumekay commented Dec 14, 2020

@Vasilius-001 Thank you for the translation!
Some English labels are not very precise, so I suggested some changes to make the Russian translation better than the original one

@pwmb pwmb requested a review from kumekay December 29, 2020 10:49
@pwmb pwmb dismissed kumekay’s stale review December 29, 2020 10:50

Added all the suggestions and missing items

@pwmb pwmb removed the ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot label Dec 29, 2020
@pwmb pwmb modified the milestones: v0.6.0, next Dec 30, 2020
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
i18n/ru/package.i18n.json Outdated Show resolved Hide resolved
Vasilius-001 and others added 6 commits January 19, 2021 11:58
Added Russian localization based on English
Co-authored-by: Sergei Silnov <po@kumekay.com>
Co-authored-by: Sergei Silnov <po@kumekay.com>
Co-authored-by: Sergei Silnov <po@kumekay.com>
Suggestions added

Co-authored-by: Sergei Silnov <po@kumekay.com>
Added Russian localization based on English
pwmb and others added 7 commits January 19, 2021 11:58
Co-authored-by: Sergei Silnov <po@kumekay.com>
Co-authored-by: Sergei Silnov <po@kumekay.com>
Co-authored-by: Sergei Silnov <po@kumekay.com>
Suggestions added

Co-authored-by: Sergei Silnov <po@kumekay.com>
Co-authored-by: Alexey Gerenkov <alexey@espressif.com>
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pwmb pwmb merged commit e71c2a9 into espressif:master Jan 19, 2021
@brianignacio5 brianignacio5 modified the milestones: next, v0.6.1 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants