Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm use of wmic in favor of Get WmiObject #1365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rm use of wmic in favor of Get WmiObject #1365

wants to merge 1 commit into from

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Dec 13, 2024 •
edited
Loading

Description

Remove deprecated wmic in favor of calling Get-WmiObject Win32_OperatingSystem from powershell.

Fixes #1364

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Configure ESP-IDF Extension"
  2. Execute action. Setup should work normally in Windows regardless of current terminal defaults shell. Check ESP-IDF: Doctor Command.
  3. Observe results.

Test Configuration:

  • ESP-IDF Version: 5.3.1
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Dec 13, 2024
@brianignacio5 brianignacio5 self-assigned this Dec 13, 2024
@brianignacio5 brianignacio5 mentioned this pull request Dec 13, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@AndreasDiet
Copy link

opened a tree of directories - my wmicCatcher is triggered, indicating wmic.exe is used
installed the vsix
opened the very same directory tree- my wmicCatcher is no longer be triggered

thanks for changing to make this extension compatible to Win11 24H2/Server 2025

radurentea
radurentea approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 added this to the v1.9.1 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radurentea radurentea radurentea approved these changes

@Fabricio-ESP Fabricio-ESP Awaiting requested review from Fabricio-ESP

Assignees

@brianignacio5 brianignacio5

Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
Milestone
v1.9.1
Development

Successfully merging this pull request may close these issues.

deprecated and removed wmic.exe is used internally (VSC-1538)
3 participants
@brianignacio5 @AndreasDiet @radurentea