[VSC-1534] Fix Install Extension Python Requirements #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
radurentea
added a commit
that referenced
this pull request
Dec 5, 2024
brianignacio5
added a commit
that referenced
this pull request
Dec 10, 2024
* Add changelog for 1.9.0 release * add flash monitor redirect in buildFlashMonitor command * add validation for getEnvVarsFromIdfTools * add IDF_PYTHON_ENV_PATH validation * Bugfix/walkthrough documentation (#1354) * Update post-installation step * Collapse all menus except commands * update activation init check settings remove extension settings await use showOnBoarding to show welcome page increase timeout of notifications increase notification timeout disable show info message on check extension setting fix lint rm console log * Use major + minor versions, remove patch version (#1360) * add cmd pwsh idf py autocomplete * add scripts to prettier ignore * update changelog * move scripts to root folder * add bypass execution policy for powershell windows --------- Co-authored-by: Radu <radu.rentea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: Constraints File Path Mismatch
The extension currently searches for ESP-IDF constraint files using the full version number (including patch version), but ESP-IDF only uses major.minor versions in the filename.
Example:
espidf.constraints.v5.3.1espidf.constraints.v5.3This PR fixes the version parsing to correctly match ESP-IDF's constraint file naming convention.
This PR changes this behavior.
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
Before this bugfix, changing the device target would not work because of the error in the logs:
The following Python requirements are not satisfiedHow has this been tested?
As described above
Test Configuration:
Checklist