Enhance/uninstall improvement #1353
Conversation
|
Download the artifacts for this pull request: |
| try { | ||
| // Try to remove from each scope, but handle errors silently | ||
| // Global settings | ||
| try { |
There was a problem hiding this comment.
You can simplify this code by reusing these try catch code into a single helper function that receives vscode.ConfigurationTarget.{Global, Workspace, WorkspaceFolder} and inspection?.{workspaceValue, globalValue, workspaceFolder} !== undefined arguments.
| ); | ||
| } | ||
|
|
||
| async function removeEspIdfSettings() { |
There was a problem hiding this comment.
Any reason why we can't have this function outside the extension.ts code ? We could move the code into a separated file.
| // Get all settings directly from configuration | ||
| const allSettings = config.inspect(""); | ||
| // Check values saved in each scope | ||
| if (allSettings?.globalValue) { |
There was a problem hiding this comment.
findIdfSettings can be simplified into a for loop with an array [allSettings.globalValue, allSettings.workspaceValue, allSettings.workspaceFolderValue]
|
Pull request has been marked as |
Fabricio-ESP
added
ongoing
Description
Added command for the user to remove all esp-idf settings from the settings.json files that can be opened with:
And also the settings from .code-workspace (multi-project)
Type of change
Steps to test this pull request
Remove all settings using the command ESP-IDF: Remove ESP-IDF Settings
How has this been tested?
Used the command and saw all the settings were removed as expected.
Test Configuration:
Checklist