Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1514] add idf path idf tools path to created example #1332

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

brianignacio5
Copy link
Collaborator

Description

  • Add the whole list of ESP-IDF setups saved in extension global state to ESP-IDF: Show Examples framework selection dropdown.
  • Add the whole list of ESP-IDF setups saved in extension global state to ESP-IDF: New Project before UI is loaded to select esp-idf to use.
  • Use current IDF Setup in newly created project from ESP-IDF: Show Examples (when different that esp-idf framework is selected).
  • Use selected esp-idf in newly created project settings.json idf.espIdfPath and idf.toolsPath.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Show Examples". Pick a esp-idf version. Create a project
  2. The newly created project should include settings.json with selected esp-idf version from step 1.
  3. Observe results.
  4. Repeat with ESP-IDF: New Project to select esp-idf version
  5. The newly created project should include settings.json with selected esp-idf version from step 4.
  • Expected behaviour:
    Selecte esp-idf version from both examples and new project wizard should be saved in new created project settings.json

  • Expected output:

How has this been tested?

Manual testing with steps from above.

Test Configuration:

  • ESP-IDF Version: 5.3.1 and 5.4
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link

github-actions bot commented Oct 30, 2024

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@Fabricio-ESP Fabricio-ESP changed the title add idf path idf tools path to created example [VSC-1514] add idf path idf tools path to created example Nov 4, 2024
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed drop down list of available IDF installations when showing examples or starting a new project.
Tested on Windows and Linux.

@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Nov 5, 2024
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left comment for a small change related to translations.

Other than that LGTM!

src/extension.ts Show resolved Hide resolved
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Nov 8, 2024
@brianignacio5 brianignacio5 merged commit d638d9b into master Nov 8, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/examples-idf-version branch November 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants