Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX/UI for creating project from examples #1278

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

radurentea
Copy link
Collaborator

Description

Improved UX/UI for creating project from examples by:

  • Changing the name of button from example projects to:
    image

  • Make use of VS Code API to use window title and window button custom names
    image

JIRA: https://jira.espressif.com:8443/browse/VSC-1413

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

  1. Use Command Palette --> ESP-IDF: Show Examples Projects
  2. After choosing an example you should see the button name as shown in the first screenshot
  3. When pressing the button the newly opened window should look like the second screenshot on windows and similar on Mac/Linux (having a custom title and the button for choosing the folder should have as well custom text)

How has this been tested?

As described above

Test Configuration:

  • ESP-IDF Version: 5.3
  • OS (Windows,Linux and macOS): All

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

- Change name of button
- Make use of VS Code API to use window title and window button custom names
@radurentea radurentea self-assigned this Aug 12, 2024
Copy link

github-actions bot commented Aug 12, 2024

Download the artifacts for this pull request:

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One note: On Ubuntu 22.04 the button in File Explorer, when you click the Select location for creating {{ selectedExample.name }} project button, does not show Select Folder for New Project just Select. I believe the Linux system itself will only take a single word or use whatever is using by default. Not of big consequence for our use case.

@radurentea
Copy link
Collaborator Author

Thank you, Brian!

@AndriiFilippov PTAL

Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Aug 30, 2024
@brianignacio5 brianignacio5 removed the stale Stale PR or Issue label Aug 30, 2024
@AndriiFilippov
Copy link
Collaborator

@radurentea hi !

Tested under:
OS - Windows 11 / MacOS / Linux Ubuntu
ESP-IDF: v5.2

button has name ✅
image

newly opened window has custom title and the button with custom text ✅

LGTM 👍

@radurentea radurentea merged commit 8209065 into master Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants