Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers and include resolution by specifying compileCommand.json path #1085

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

radurentea
Copy link
Collaborator

Description

Added compileCommands.json path, this will help getting rid of the squiggly lines in C files for the esp projects after build.

Task: https://jira.espressif.com:8443/browse/VSC-1234

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Create new esp project
  2. Build project
  3. Open the main c file of the project (Ex for blink project: blink_example_main.c)
  • Expected behaviour:
    The file should display no errors (no squiggly red lines)

How has this been tested?

Created esp projects using all possible options in VS Code Extension on Windows 11 with no issues shown after building the projects.

Test Configuration:

  • ESP-IDF Version: 5.1.2
  • OS (Windows,Linux and macOS): Windows 11

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link

Download the artifacts for this pull request:

@radurentea radurentea self-assigned this Nov 24, 2023
@kolipakakondal kolipakakondal added this to the v1.7.0 milestone Dec 1, 2023
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

@radurentea hi !

Tested:
OS - Windows 10 / Linux Ubuntu 20.04
ESP-IDF: v5.1.2

LGTM 👍

@radurentea radurentea merged commit caac086 into master Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants