Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/idf versions #1001

Merged
merged 7 commits into from
Jun 30, 2023
Merged

Bugfix/idf versions #1001

merged 7 commits into from
Jun 30, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jun 29, 2023

Description

  • Add download with retries to idf_versions.txt file and update local fallback file.
  • Add timestamps IDF version validation (IDF >= 4.4)
  • Add changelog for v1.6.4 release
  • Fix workspace folders scope in TaskManager.addTask
  • Update readme

Fixes #998
Fixes #990

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "Configure ESP-IDF extension" command
  2. Execute action.
  3. Observe results. The setup wizard should appear and work.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Jun 29, 2023
@brianignacio5 brianignacio5 added this to the 1.6.4 milestone Jun 29, 2023
@brianignacio5 brianignacio5 self-assigned this Jun 29, 2023
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 merged commit 4962717 into master Jun 30, 2023
@brianignacio5 brianignacio5 deleted the bugfix/idf-versions branch June 30, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
1 participant