IEP-562 Fix: Avoid appending to existing PATH env variable in CDT build #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolipakakondal
changed the title
Collaborator
|
LGTM |
Collaborator
Author
|
Thanks @sigmaaa for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having
python dependencies are not satisfiedissue with the Bosch customer. This has happened because they are having multiple versions of python versions installed and CMake build is picking up the python version from the system instead of python from the CDT build PATH.Let's rely only on
idf.py exportcommandPATHoutput for building idf projects. That is having all the required paths and also don't see a need to append to the existing path. That basically avoids configuring multiple tool chains on the path environment also.