ci: update the beta workflow and merge release&beta ci #1280
Conversation
WalkthroughThe "Beta builds" GitHub Actions workflow was deleted, removing automated beta build and deployment. The main release workflow was updated to handle both stable and beta tags, dynamically adjusting S3 upload and redirect paths based on the release type, and consolidating beta and stable asset handling into a single pipeline. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
.github/workflows/ci_release.yml (1)
323-332: Hard-coded bucket nameespdldatabypasses${{ secrets.DL_BUCKET }}
Earlier commands honor the secret bucket variable; these fouraws s3api put-objectcalls do not.
If the bucket ever changes, the redirects will silently break.- aws s3api put-object --acl=public-read --bucket espdldata --key ... + aws s3api put-object --acl=public-read --bucket ${{ secrets.DL_BUCKET }} --key ...
🧹 Nitpick comments (2)
.github/workflows/ci_release.yml (2)
58-59: Trailing whitespace – please clean up for linting compliance
Line 58 contains only indentation + spaces; YAML-lint flags it.
Not functional, but it breaksyamllint -d relaxed.
260-277: Minor shell-safety improvements for version parsing block
- Wrap variable expansions in double-quotes to avoid word-splitting problems if the tag is ever malformed.
IS_BETAcan be exported directly instead of using an intermediate variable.- TAG="${GITHUB_REF##*/}" - VERSION="${TAG#v}" + TAG="${GITHUB_REF##*/}" + VERSION="${TAG#v}" if [[ "$TAG" == *"-beta"* ]]; then - IS_BETA="true" + IS_BETA=true UPLOAD_PATH="beta" REDIRECT_PATH="beta" else - IS_BETA="false" + IS_BETA=false UPLOAD_PATH="latest" REDIRECT_PATH="latest" fiNot critical, but it tightens the script.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci_beta.yml(0 hunks).github/workflows/ci_release.yml(4 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/ci_beta.yml
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/ci_release.yml
7-7: character '' is invalid for branch and tag names. only special characters [, ?, +, *, , ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
(glob)
7-7: character '' is invalid for branch and tag names. only special characters [, ?, +, *, , ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
(glob)
🪛 YAMLlint (1.37.1)
.github/workflows/ci_release.yml
[error] 58-58: trailing spaces
(trailing-spaces)
[error] 316-316: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build_macos
🔇 Additional comments (1)
.github/workflows/ci_release.yml (1)
302-306:aws s3 rmwipes the whole channel before upload – risk of race conditions
If two workflows (e.g., two parallel beta builds) run concurrently, the second job can delete assets uploaded by the first.
Consider either:
• using versioned folders only, and keepinglatest/betaas redirects, or
• moving thermcall after a successfulcp --recursivewith the--exclude "*" --include "*.tmp"pattern.Flagging for your awareness.
| tags: | ||
| - "v[0-9]+.[0-9]+.[0-9]+" | ||
| - "v[0-9]+\\.[0-9]+\\.[0-9]+-beta" | ||
|
|
There was a problem hiding this comment.
Tag-filter glob is syntactically invalid – workflow will never trigger on beta tags
GitHub Actions push.tags uses simple glob patterns, not regex.
Characters like + and the escaped \. are illegal in this context and will be rejected by the runner (actionlint already flags this).
- - "v[0-9]+\\.[0-9]+\\.[0-9]+-beta"
+ - "v*-beta"If you really want to constrain the number of numeric sections, you can use:
- "v[0-9]*.[0-9]*.[0-9]*-beta"but keep the asterisks and drop the backslashes & plus signs.
Failing to fix this will block every beta release.
🧰 Tools
🪛 actionlint (1.7.7)
7-7: character '' is invalid for branch and tag names. only special characters [, ?, +, *, , ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
(glob)
7-7: character '' is invalid for branch and tag names. only special characters [, ?, +, *, , ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
(glob)
🤖 Prompt for AI Agents
In .github/workflows/ci_release.yml around lines 5 to 8, the tag filter uses
invalid regex syntax with plus signs and escaped dots, which GitHub Actions does
not support for push.tags. Replace the regex patterns with valid glob patterns
by removing plus signs and backslashes, and use asterisks instead, for example,
change "v[0-9]+\\.[0-9]+\\.[0-9]+-beta" to "v[0-9]*.[0-9]*.[0-9]*-beta" to
ensure the workflow triggers correctly on beta tags.
* ci: update the beta workflow and merge release&beta ci
Description
Please include a summary of the change and which issue is fixed.
Fixes # (IEP-XXX)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit