-
Notifications
You must be signed in to change notification settings - Fork 133
IEP-1602 Prevent Exception When EIM Closes Before eim.json Is Created #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@sigmaaa hi ! EIM is opened from a fresh IDE launch and closed before the tool installation completes and eim.json is generated - no exception ✅ LGTM 👍 |
Description
An exception occurs if EIM is opened from a fresh IDE launch and closed before the tool installation completes and eim.json is generated.
java.lang.NullPointerException: Cannot invoke "com.espressif.idf.core.tools.vo.EimJson.getIdfInstalled()" because "com.espressif.idf.ui.tools.manager.pages.ESPIDFMainTablePage.eimJson" is null
at com.espressif.idf.ui.tools.manager.pages.ESPIDFMainTablePage.refreshEditorUI(ESPIDFMainTablePage.java:195)
at com.espressif.idf.ui.tools.EimButtonLaunchListener.lambda$1(EimButtonLaunchListener.java:105)
Fixes # (IEP-1602)
Type of change
Please delete options that are not relevant.
How has this been tested?
Open fresh workspace → launch EIM via IDE → close EIM before tools install -> no NullPointerException: eimJson is null when calling getIdfInstalled()
Test Configuration:
Dependent components impacted by this PR:
Checklist