Skip to content

IEP-1597 Remove redundant editor-closing code #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolipakakondal merged 1 commit into from
Jul 14, 2025
+0 −20
Merged

IEP-1597 Remove redundant editor-closing code #1268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/tools/EspressifToolStartup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ private void notifyMissingTools()

private void downloadAndLaunchEim()
{
closeWelcomePage();
Job downloadJob = new Job("Download and Launch EIM")
{

Expand All @@ -284,25 +283,6 @@ protected IStatus run(IProgressMonitor monitor)
downloadJob.schedule();
}

private void closeWelcomePage()
{
Display.getDefault().asyncExec(() -> {
IWorkbench workbench = PlatformUI.getWorkbench();
if (workbench != null)
{
IWorkbenchWindow window = workbench.getActiveWorkbenchWindow();
if (window != null)
{
IIntroManager introManager = workbench.getIntroManager();
if (introManager.getIntro() != null)
{
introManager.closeIntro(introManager.getIntro());
}
}
}
});
}

private MessageConsoleStream getConsoleStream(boolean errorStream)
{
IDFConsole idfConsole = new IDFConsole();
Expand Down
Loading