IEP-1585: Fixed eim old config import handling

[alirana01]

Description

The issue is that we are detecting if the eim executable is present in the system in user home directory under the .espressif/eim_gui/eim

or in applications on macos but when handling old config export the path passed was still null.

Fixes # (IEP-1585)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Use an older workspace for this that has preconfigured IDF inside.
Make sure that eim is placed in user home under .espressif/eim_gui/eim or .espressif/eim_gui/eim.exe (Windows only)
For Mac put eim.app in Applications.
eim_idf.json must be removed and eim must not be launched.

Open the IDE and it should be able to detect old configuration and convert it.

Test Configuration:

• ESP-IDF Version: any
• OS (Windows,Linux and macOS): all

Checklist

• PR Self Reviewed
• Applied Code formatting
• Verified on all platforms - Windows,Linux and macOS

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[AndriiFilippov]

@alirana01 hi !
Tested under:

OS - Windows 11

1. the most common scenario will be, in my opinion, when the user don't want to install any ESP-IDF via EIM, the user will want just to convert the existing one, so for this scenario user will:
   a) run old workspace in the IDE v4.0.0
   b) get the message about EIM missing -> he will install it
   c) EIM will open and user will close it since there is no UI for import command in EIM GUI yet.

so, for the old workspaces, we need to run import command right after the EIM is been downloaded.
for now, I am getting this error following this scenario:

java.io.FileNotFoundException: C:\Espressif\tools\eim_idf.json (The system cannot find the file specified)
	at java.base/java.io.FileInputStream.open0(Native Method)
	at java.base/java.io.FileInputStream.open(FileInputStream.java:213)
	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:152)
	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:106)
	at java.base/java.io.FileReader.<init>(FileReader.java:60)
	at com.espressif.idf.core.tools.EimIdfConfiguratinParser.load(EimIdfConfiguratinParser.java:25)
	at com.espressif.idf.core.tools.EimIdfConfiguratinParser.getEimJson(EimIdfConfiguratinParser.java:37)
	at com.espressif.idf.core.tools.ToolInitializer.loadEimJson(ToolInitializer.java:73)
	at com.espressif.idf.ui.tools.EspressifToolStartup$StartupClassDownloadEimDownloadListener.lambda$2(EspressifToolStartup.java:374)
	at com.espressif.idf.core.tools.EimLoader$2.done(EimLoader.java:406)
	at org.eclipse.core.internal.jobs.JobListeners.sendEvent(JobListeners.java:160)
	at org.eclipse.core.internal.jobs.JobListeners.sendEventsAsync(JobListeners.java:140)
	at org.eclipse.core.internal.jobs.JobListeners.waitAndSendEvents(JobListeners.java:80)
	at org.eclipse.core.internal.jobs.JobManager.withWriteLock(JobManager.java:551)
	at org.eclipse.core.internal.jobs.JobManager.endJob(JobManager.java:756)
	at org.eclipse.core.internal.jobs.WorkerPool.endJob(WorkerPool.java:117)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:83)

[AndriiFilippov]

@alirana01 hi !
Tested under:

OS - Windows 11

2. I did have the eim installed to the correct path on Windows 11: C:\Users\andri\.espressif\eim_gui\eim-gui-windows-x64.exe
   but the IDE still was not able to detect it and just download and re-write it to the same path

[AndriiFilippov]

@alirana01
Tested: Windows 11 / Mac arm64
LGTM 👍

[sigmaaa]

LGTM