Skip to content

Conversation

@alirana01
Copy link
Collaborator

@alirana01 alirana01 commented Jun 11, 2025

Description

Possible issues with older version of java in lsp and cdt

Fixes # (IEP-1549)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Test the builds from release branch after this is merged

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Updated the macOS and Windows build processes to use Java 21 for improved compatibility and support.

@coderabbitai
Copy link

coderabbitai bot commented Jun 11, 2025

Walkthrough

The GitHub Actions workflows for macOS and Windows builds were updated to use Java 21 and the latest version of the Java setup action. Both workflows previously used Java 17 with actions/setup-java@v3 and now use Java 21 with actions/setup-java@v4. No other workflow logic was changed.

Changes

Files Change Summary
.github/workflows/ci_release.yml,
.github/workflows/ci_windows.yml
Updated Java setup step: now uses actions/setup-java@v4 and JDK 21 instead of actions/setup-java@v3 and JDK 17.

Poem

A hop and a skip, we leap ahead,
Java 21, the future we tread!
Workflows refreshed, actions anew,
Rabbits rejoice in what we now do.
With v4 in our paws, we code with delight—
CI runs smoother, from morning to night!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d94c4b and 7808b29.

📒 Files selected for processing (2)
  • .github/workflows/ci_release.yml (1 hunks)
  • .github/workflows/ci_windows.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build_macos
🔇 Additional comments (2)
.github/workflows/ci_windows.yml (1)

40-45: Upgrade Windows CI to JDK 21 with actions/setup-java@v4.
The Java setup step now uses JDK 21 via actions/setup-java@v4, matching the macOS release workflow and ensuring consistency across platforms.

.github/workflows/ci_release.yml (1)

20-25: Upgrade macOS release build to JDK 21 with actions/setup-java@v4.
This replaces the previous JDK 17 setup with Java 21 and the latest setup action, aligning the macOS release pipeline with the Windows CI configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alirana01 alirana01 self-assigned this Jun 11, 2025
Copy link
Collaborator

@kolipakakondal kolipakakondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alirana01 alirana01 added this to the v4.0.0 milestone Jul 1, 2025
@kolipakakondal kolipakakondal merged commit 4ec9db2 into master Nov 6, 2025
2 of 4 checks passed
@kolipakakondal kolipakakondal deleted the IEP-1549 branch November 6, 2025 12:27
kolipakakondal added a commit that referenced this pull request Nov 19, 2025
* IEP-1549: Updating java version for release and builds (#1241)

Co-authored-by: Kondal Kolipaka <kondal.kolipaka@espressif.com>

* IEP-1650 Convert NVS Title Area dialog to the editor (#1339)

* feat: convertin NVS dialog to the editor

* fix: replace enum with EnumMap

* feat: optimizing performance

* feat: improving tooltip performance

* feat: move to the new API, improving tooltip

* fix: fixed potential NPE is there is no selected project

* fix: addressing coderabbit point about NPE

* fix: remove duplicate editor in the plugin.xml

* feat: improved status messaging

* feat: setting the default partition size to improve the UX

* fix: set dirty false after save action

* fix: addressing coderabbit comment about possible NPE

* fix: addressing minor fix about filter path

* feat: saving the status of fields based on the project

* feat: improving UX by utilizing ColumnLabelProvider

* fix: return non editable for first row

* feat: refactoring to reduce size of the EditorPage and make it easier to read

* feat: refactoring - moved storing preference logic to the separate class

* fix: fixed typo in the methods names

* IEP-1652 Add project selector to ESP-IDF Terminal launch workflow (#1343)

* feat: added a project selector on the terminal page

* feat: update terminal title for better UX on windows

* fix: added Project name label to the Messages

* fix: allowing empty project

---------

Co-authored-by: Ali Azam Rana <85216275+alirana01@users.noreply.github.com>
Co-authored-by: Denys Almazov <almazovdenys@gmail.com>
Shen7436 pushed a commit that referenced this pull request Nov 27, 2025
* IEP-1549: Updating java version for release and builds (#1241)

Co-authored-by: Kondal Kolipaka <kondal.kolipaka@espressif.com>

* IEP-1650 Convert NVS Title Area dialog to the editor (#1339)

* feat: convertin NVS dialog to the editor

* fix: replace enum with EnumMap

* feat: optimizing performance

* feat: improving tooltip performance

* feat: move to the new API, improving tooltip

* fix: fixed potential NPE is there is no selected project

* fix: addressing coderabbit point about NPE

* fix: remove duplicate editor in the plugin.xml

* feat: improved status messaging

* feat: setting the default partition size to improve the UX

* fix: set dirty false after save action

* fix: addressing coderabbit comment about possible NPE

* fix: addressing minor fix about filter path

* feat: saving the status of fields based on the project

* feat: improving UX by utilizing ColumnLabelProvider

* fix: return non editable for first row

* feat: refactoring to reduce size of the EditorPage and make it easier to read

* feat: refactoring - moved storing preference logic to the separate class

* fix: fixed typo in the methods names

* IEP-1652 Add project selector to ESP-IDF Terminal launch workflow (#1343)

* feat: added a project selector on the terminal page

* feat: update terminal title for better UX on windows

* fix: added Project name label to the Messages

* fix: allowing empty project

---------

Co-authored-by: Ali Azam Rana <85216275+alirana01@users.noreply.github.com>
Co-authored-by: Denys Almazov <almazovdenys@gmail.com>
Shen7436 pushed a commit that referenced this pull request Nov 27, 2025
Co-authored-by: Kondal Kolipaka <kondal.kolipaka@espressif.com>
Shen7436 pushed a commit that referenced this pull request Nov 27, 2025
Co-authored-by: Kondal Kolipaka <kondal.kolipaka@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants