Skip to content

[WIP] Release/v4.0.0 This is just to have the release 4.0 builds for testing (Please dont merge it yet #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alirana01 wants to merge 35 commits into from
Closed

[WIP] Release/v4.0.0 This is just to have the release 4.0 builds for testing (Please dont merge it yet #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
4986f0d
IEP-1334: EIM Integration (#1116)
alirana01 Apr 24, 2025
b662d60
fixes after merge
alirana01 May 7, 2025
4206fab
IEP-1516: Automatic update to IDE with filewatcher (#1210)
alirana01 Jun 10, 2025
899e9e8
IEP 1517: Handling case for conversion of existing json file to eim_i…
alirana01 Jun 10, 2025
913065a
IEP-1529: Fix for system python executable (#1239)
alirana01 Jun 16, 2025
d1b3b21
IEP-1555: Removed python dependencies installation (#1254)
alirana01 Jun 18, 2025
dd96838
IEP-1554: Launch and Download EIM (#1251)
alirana01 Jul 1, 2025
495d94b
feat: made the Esp-idf setup msg more informative (#1258)
sigmaaa Jul 1, 2025
a59d024
IEP-1577: Eim default directory added based on documentation (#1261)
alirana01 Jul 1, 2025
22a4eef
IEP-1557: Documentation for the ESP-IDF Manager (#1257)
alirana01 Jul 2, 2025
c2bcc64
doc updated and image fixed
alirana01 Jul 2, 2025
0104b14
image fixed
alirana01 Jul 2, 2025
e31dd3e
image fixed
alirana01 Jul 2, 2025
880f602
possible syntax fix
alirana01 Jul 2, 2025
54f2737
another fix
alirana01 Jul 2, 2025
738aa57
fixing imaage name
alirana01 Jul 2, 2025
16c7bb1
added file to correct directory
alirana01 Jul 2, 2025
22960a6
doc update
alirana01 Jul 2, 2025
430b257
IEP-1585: Fixed eim old config import handling (#1263)
alirana01 Jul 4, 2025
a9f75c8
IEP-1584 Avoid Simultaneous Modals on Old Config Detection (#1264)
sigmaaa Jul 7, 2025
16a0220
IEP-1583: Closing old editor window when old workspace is found (#1262)
alirana01 Jul 9, 2025
4108e0b
fix: fixed exception and added loggin when eim.json is missing (#1270)
sigmaaa Jul 14, 2025
66aa87b
IEP-1596 Handle Redundant File Watcher Events for eim_idf.json (#1267)
sigmaaa Jul 14, 2025
cd9c617
fix: remove redundant closeWelcomePage (#1268)
sigmaaa Jul 14, 2025
e097ec3
IEP-1602 Prevent Exception When EIM Closes Before eim.json Is Created…
sigmaaa Jul 15, 2025
cf93936
IEP-1590: autoimport of old configuration (#1275)
alirana01 Jul 24, 2025
0b67eff
fix: bump version to v3.6.0 (#1279)
kolipakakondal Jul 24, 2025
9d68ad9
ci: update the beta workflow and merge release&beta ci (#1280)
kolipakakondal Jul 29, 2025
10b5d98
fix: bump version to v4.0.0 (#1282)
kolipakakondal Jul 29, 2025
571f44d
fix: update the tags for beta versions
kolipakakondal Jul 29, 2025
d9880e6
fix: code cleanup
kolipakakondal Jul 29, 2025
4b1674c
fix: update CI workflow regex patterns to support v4.0.0-beta.1 tags
kolipakakondal Jul 29, 2025
8b6303a
fix: correct keystore file path in CI workflow
kolipakakondal Jul 29, 2025
3acf3c4
Revert "fix: correct keystore file path in CI workflow"
kolipakakondal Jul 29, 2025
fa28fd9
fix: regex issue with the tags
kolipakakondal Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,31 @@ name: Java CI with Maven

on:
push:
branches: [ master ]
branches:
- master
- release/**
pull_request:
branches: [ master ]
branches:
- master
- release/**
Comment on lines +8 to +14
Copy link

@coderabbitai coderabbitai bot May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix YAML indentation under triggers
The list items for push.branches and pull_request.branches are mis-indented (5 spaces instead of 6). Correcting this will prevent YAML parsing issues.

   on:
     push:
-    branches:
-     - master
-     - release/**
+    branches:
+      - master
+      - release/**
     pull_request:
-    branches:
-     - master
-     - release/**
+    branches:
+      - master
+      - release/**
🧰 Tools
🪛 YAMLlint (1.35.1)

[warning] 9-9: wrong indentation: expected 6 but found 5

(indentation)

[warning] 13-13: wrong indentation: expected 6 but found 5

(indentation)


jobs:
build:
build_linux:

runs-on:
- self-hosted
- eclipse
- BrnoUBU0004
runs-on: [self-hosted, eclipse, BrnoUBU0004]

steps:
- uses: actions/checkout@v2

- name: Clone IDF Release From Github
uses: actions/checkout@v2
with:
repository: espressif/esp-idf
path: dependencies/idf-tools
submodules: 'true'
ref: release/v5.1
- uses: actions/checkout@v4
Copy link

@coderabbitai coderabbitai bot Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Correct indentation of checkout step
The - uses: actions/checkout@v4 line is only indented 4 spaces under steps. It should be indented 6 spaces to align with YAML expectations:

   steps:
-  - uses: actions/checkout@v4
+     - uses: actions/checkout@v4

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools
🪛 YAMLlint (1.37.1)

[warning] 22-22: wrong indentation: expected 6 but found 4

(indentation)

🤖 Prompt for AI Agents 
In .github/workflows/ci.yml at line 22, the indentation of the line '- uses:
actions/checkout@v4' is incorrect; it is currently indented 4 spaces under
'steps' but should be indented 6 spaces to conform to YAML syntax. Adjust the
indentation of this line to 6 spaces so it aligns properly with other step
entries under 'steps'.


- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: '3.10'
python-version: '3.10'
Comment on lines 24 to +27
Copy link

@coderabbitai coderabbitai bot May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Update Python setup action to latest version
The workflow uses actions/setup-python@v2, which is outdated. Align with other workflows and benefit from bug fixes by upgrading to:

-    uses: actions/setup-python@v2
+    uses: actions/setup-python@v4
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: '3.10'
python-version: '3.10'
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.10'
🧰 Tools
🪛 actionlint (1.7.4)

25-25: the runner of "actions/setup-python@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


- name: Install ESP-IDF via eim
uses: espressif/install-esp-idf-action@v1
with:
version: 'v5.3'

Comment on lines +29 to 33
Copy link

@coderabbitai coderabbitai bot Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Tab characters break YAML parsing

Line 29 contains two \t characters after the step name. YAML forbids tabs.

-    - name: Install ESP-IDF via eim		
+    - name: Install ESP-IDF via eim
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Install ESP-IDF via eim
uses: espressif/install-esp-idf-action@v1
with:
version: 'v5.3'
- name: Install ESP-IDF via eim
uses: espressif/install-esp-idf-action@v1
with:
version: 'v5.3'
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 29-29: syntax error: found character '\t' that cannot start any token

(syntax)

🤖 Prompt for AI Agents 
In .github/workflows/ci.yml at lines 29 to 33, replace the tab characters after
the step name "Install ESP-IDF via eim" with spaces, as YAML does not allow tab
characters for indentation. Ensure all indentation uses spaces consistently to
fix the YAML parsing error.

- name: Set up Maven
uses: stCarolas/setup-maven@v5
Expand All @@ -42,8 +40,9 @@ jobs:
uses: actions/setup-java@v4
with:
java-version: '21'
distribution: 'temurin'

distribution: 'temurin'
cache: 'maven'
Comment on lines +43 to +44
Copy link

@coderabbitai coderabbitai bot Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove trailing spaces
The lines for distribution: 'temurin' and cache: 'maven' end with extra spaces, which YAMLlint flags. Trim them:

-        distribution: 'temurin'    
+        distribution: 'temurin'
-        cache: 'maven'
+        cache: 'maven'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
distribution: 'temurin'
cache: 'maven'
distribution: 'temurin'
cache: 'maven'
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 43-43: trailing spaces

(trailing-spaces)

🤖 Prompt for AI Agents 
In .github/workflows/ci.yml at lines 43 to 44, remove the trailing spaces at the
end of the lines containing "distribution: 'temurin'" and "cache: 'maven'".
Ensure there are no extra spaces after the values to comply with YAMLlint rules.


- name: Build with Maven
run: export NO_AT_BRIDGE=1 && mvn clean verify -Djarsigner.skip=true -DskipTests=false -DtestWorkspace=/opt/actions-runner/_work/workspace

Expand Down
165 changes: 0 additions & 165 deletions .github/workflows/ci_beta.yml
View file
Open in desktop

This file was deleted.

38 changes: 25 additions & 13 deletions .github/workflows/ci_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
tags:
- "v[0-9]+.[0-9]+.[0-9]+"
- "v[0-9]+.[0-9]+.[0-9]+-beta.*"

env:
ARCHIVE_PREFIX: com.espressif.idf.update-
Expand Down Expand Up @@ -54,7 +55,7 @@ jobs:
echo "codesigning espressif-ide-macosx.cocoa.x86_64"
/usr/bin/codesign --entitlements $PWD/releng/com.espressif.idf.product/entitlements/espressif-ide.entitlement --options runtime --force -s "ESPRESSIF SYSTEMS (SHANGHAI) CO., LTD. (QWXF6GB4AV)" $PWD/releng/com.espressif.idf.product/target/products/com.espressif.idf.product/macosx/cocoa/x86_64/Espressif-IDE.app -v
/usr/bin/codesign -v -vvv --deep $PWD/releng/com.espressif.idf.product/target/products/com.espressif.idf.product/macosx/cocoa/x86_64/Espressif-IDE.app

echo "codesigning espressif-ide-macosx.cocoa.aarch64"
/usr/bin/codesign --entitlements $PWD/releng/com.espressif.idf.product/entitlements/espressif-ide.entitlement --options runtime --force -s "ESPRESSIF SYSTEMS (SHANGHAI) CO., LTD. (QWXF6GB4AV)" $PWD/releng/com.espressif.idf.product/target/products/com.espressif.idf.product/macosx/cocoa/aarch64/Espressif-IDE.app -v
/usr/bin/codesign -v -vvv --deep $PWD/releng/com.espressif.idf.product/target/products/com.espressif.idf.product/macosx/cocoa/aarch64/Espressif-IDE.app
Expand Down Expand Up @@ -256,14 +257,23 @@ jobs:
- name: Extract version from tag and prepare folder
id: get_version
run: |
if [[ "${GITHUB_REF}" == refs/tags/v* ]]; then
TAG="${GITHUB_REF##*/}"
VERSION="${TAG#v}"
TAG="${GITHUB_REF##*/}"
VERSION="${TAG#v}"
if [[ "$TAG" == *"-beta"* ]]; then
IS_BETA="true"
UPLOAD_PATH="beta"
REDIRECT_PATH="beta"
else
VERSION="testing"
IS_BETA="false"
UPLOAD_PATH="latest"
REDIRECT_PATH="latest"
fi
echo "VERSION=$VERSION" >> $GITHUB_ENV
echo "IS_BETA=$IS_BETA" >> $GITHUB_ENV
echo "UPLOAD_PATH=$UPLOAD_PATH" >> $GITHUB_ENV
echo "REDIRECT_PATH=$REDIRECT_PATH" >> $GITHUB_ENV
echo "FOLDER=v$VERSION" >> $GITHUB_ENV
echo "TAG=$TAG" >> $GITHUB_ENV

- name: Rename DMGs with version suffix
run: |
Expand All @@ -289,31 +299,33 @@ jobs:
- name: Upload build assets to dl.espressif.com
run: |
VERSION="${{ env.VERSION }}"
UPLOAD_PATH="${{ env.UPLOAD_PATH }}"
REDIRECT_PATH="${{ env.REDIRECT_PATH }}"

aws s3 rm "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/updates/latest" --recursive
aws s3 rm "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/updates/$UPLOAD_PATH" --recursive

# Extract the update site from the versioned zip and upload its contents
TMP_UPDATE_DIR="update_site_tmp"
mkdir -p "$TMP_UPDATE_DIR"
unzip -q "com.espressif.idf.update-v$VERSION.zip" -d "$TMP_UPDATE_DIR"
echo "Contents of $TMP_UPDATE_DIR:"
ls -l "$TMP_UPDATE_DIR"
aws s3 cp --acl=public-read --recursive "$TMP_UPDATE_DIR/artifacts/update/" "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/updates/latest"
aws s3 cp --acl=public-read --recursive "$TMP_UPDATE_DIR/artifacts/update/" "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/updates/$UPLOAD_PATH"
aws s3 cp --acl=public-read --recursive "$TMP_UPDATE_DIR/artifacts/update/" "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/updates/v$VERSION"
aws s3 cp --acl=public-read ./releng/index.html "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/updates/latest/"
aws s3 cp --acl=public-read ./releng/index.html "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/updates/$UPLOAD_PATH/"

aws s3 cp --acl=public-read "com.espressif.idf.update-v$VERSION.zip" "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/updates/"
aws s3 cp --acl=public-read --recursive artifacts/linux/ "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/ide/"
aws s3 cp --acl=public-read "artifacts/macos_x86/Espressif-IDE-macosx-cocoa-x86_64-v$VERSION.dmg" "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/ide/"
aws s3 cp --acl=public-read "artifacts/macos_arm/Espressif-IDE-macosx-cocoa-aarch64-v$VERSION.dmg" "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/ide/"
aws s3 cp --acl=public-read "Espressif-IDE-$VERSION-win32.win32.x86_64.zip" "s3://${{ secrets.DL_BUCKET }}/dl/idf-eclipse-plugin/ide/"

aws cloudfront create-invalidation --distribution-id ${{ secrets.DL_DISTRIBUTION_ID }} --paths "/dl/idf-eclipse-plugin/updates/latest/*"
aws cloudfront create-invalidation --distribution-id ${{ secrets.DL_DISTRIBUTION_ID }} --paths "/dl/idf-eclipse-plugin/updates/$UPLOAD_PATH/*"

aws s3api put-object --acl=public-read --bucket espdldata --key "dl/idf-eclipse-plugin/ide/Espressif-IDE-win32.win32.x86_64/latest" --website-redirect-location "/dl/idf-eclipse-plugin/ide/Espressif-IDE-$VERSION-win32.win32.x86_64.zip"
aws s3api put-object --acl=public-read --bucket espdldata --key "dl/idf-eclipse-plugin/ide/Espressif-IDE-win32.win32.x86_64/$REDIRECT_PATH" --website-redirect-location "/dl/idf-eclipse-plugin/ide/Espressif-IDE-$VERSION-win32.win32.x86_64.zip"

aws s3api put-object --acl=public-read --bucket espdldata --key "dl/idf-eclipse-plugin/ide/Espressif-IDE-macosx-cocoa-x86_64/latest" --website-redirect-location "/dl/idf-eclipse-plugin/ide/Espressif-IDE-macosx-cocoa-x86_64-v$VERSION.dmg"
aws s3api put-object --acl=public-read --bucket espdldata --key "dl/idf-eclipse-plugin/ide/Espressif-IDE-macosx-cocoa-x86_64/$REDIRECT_PATH" --website-redirect-location "/dl/idf-eclipse-plugin/ide/Espressif-IDE-macosx-cocoa-x86_64-v$VERSION.dmg"

aws s3api put-object --acl=public-read --bucket espdldata --key "dl/idf-eclipse-plugin/ide/Espressif-IDE-macosx-cocoa-aarch64/latest" --website-redirect-location "/dl/idf-eclipse-plugin/ide/Espressif-IDE-macosx-cocoa-aarch64-v$VERSION.dmg"
aws s3api put-object --acl=public-read --bucket espdldata --key "dl/idf-eclipse-plugin/ide/Espressif-IDE-macosx-cocoa-aarch64/$REDIRECT_PATH" --website-redirect-location "/dl/idf-eclipse-plugin/ide/Espressif-IDE-macosx-cocoa-aarch64-v$VERSION.dmg"

aws s3api put-object --acl=public-read --bucket espdldata --key "dl/idf-eclipse-plugin/ide/Espressif-IDE-linux.gtk.x86_64/latest" --website-redirect-location "/dl/idf-eclipse-plugin/ide/Espressif-IDE-$VERSION-linux.gtk.x86_64.tar.gz"
aws s3api put-object --acl=public-read --bucket espdldata --key "dl/idf-eclipse-plugin/ide/Espressif-IDE-linux.gtk.x86_64/$REDIRECT_PATH" --website-redirect-location "/dl/idf-eclipse-plugin/ide/Espressif-IDE-$VERSION-linux.gtk.x86_64.tar.gz"
8 changes: 6 additions & 2 deletions .github/workflows/ci_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@ name: Java CI with Maven on Windows

on:
push:
branches: [ master ]
branches:
- master
- release/**
pull_request:
branches: [ master ]
branches:
- master
- release/**
Comment on lines +8 to +14
Copy link

@coderabbitai coderabbitai bot May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix YAML indentation under triggers
Indentation of list items under both push.branches and pull_request.branches is off by one space (5 vs. 6), which can lead to malformed YAML or unexpected behavior.

Proposed patch:

   on:
     push:
-    branches:
-     - master
-     - release/**
+    branches:
+      - master
+      - release/**
     pull_request:
-    branches:
-     - master
-     - release/**
+    branches:
+      - master
+      - release/**
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
branches:
- master
- release/**
pull_request:
branches: [ master ]
branches:
- master
- release/**
on:
push:
branches:
- master
- release/**
pull_request:
branches:
- master
- release/**
🧰 Tools
🪛 YAMLlint (1.35.1)

[warning] 9-9: wrong indentation: expected 6 but found 5

(indentation)

[warning] 13-13: wrong indentation: expected 6 but found 5

(indentation)


jobs:
build_windows:
Expand Down
2 changes: 1 addition & 1 deletion bundles/com.espressif.idf.branding/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: com.espressif.idf.branding;singleton:=true
Bundle-Version: 3.5.0.qualifier
Bundle-Version: 4.0.0.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Bundle-RequiredExecutionEnvironment: JavaSE-17
1 change: 1 addition & 0 deletions bundles/com.espressif.idf.core/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ Export-Package: com.espressif.idf.core,
com.espressif.idf.core.tools,
com.espressif.idf.core.tools.util,
com.espressif.idf.core.tools.vo,
com.espressif.idf.core.tools.watcher,
com.espressif.idf.core.util,
com.espressif.idf.core.variable,
org.json.simple,
Expand Down
Loading
Loading